Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46525: switch back to raising on partial output errors by default #309

Merged
merged 3 commits into from
Oct 3, 2024
Merged

DM-46525: switch back to raising on partial output errors by default #309

merged 3 commits into from
Oct 3, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Sep 27, 2024 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (6c9b749) to head (f56ab26).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          50       50           
  Lines        4427     4427           
  Branches      718      718           
=======================================
  Hits         3958     3958           
  Misses        336      336           
  Partials      133      133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

parejkoj
parejkoj approved these changes Oct 3, 2024
View reviewed changes
python/lsst/ctrl/mpexec/cli/opt/options.py
@@ -450,9 +450,10 @@
)

raise_on_partial_outputs_option = MWOptionDecorator(
"--raise-on-partial-outputs",
"--raise-on-partial-outputs/--no-raise-on-partial-outputs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool, I didn't know you could do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned about it on this ticket, too!

@TallJimbo TallJimbo merged commit 8a8e908 into main Oct 3, 2024
15 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-46525 branch October 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TallJimbo @parejkoj